Skip to content

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Apr 7, 2023

This commit handles two bits of feedback from the live website: a small command adjustment and the listed type for a parameter. Changes for the NGINX product naming conventions are also included in this commit for the two affected files.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

This commit handles two bits of feedback from the live website: a small
command adjustment and the listed type for a parameter. Changes for the
NGINX product naming conventions are also included in this commit for
the two affected files.
@ADubhlaoich ADubhlaoich requested a review from a team as a code owner April 7, 2023 16:29
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #3736 (7cb0e26) into main (87b8a58) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3736      +/-   ##
==========================================
+ Coverage   52.39%   52.41%   +0.02%     
==========================================
  Files          59       59              
  Lines       16902    16902              
==========================================
+ Hits         8855     8859       +4     
+ Misses       7750     7748       -2     
+ Partials      297      295       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomasohaodha tomasohaodha merged commit 0b7533e into main Apr 26, 2023
@tomasohaodha tomasohaodha deleted the apr-7-minor-updates branch April 26, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants