Move build docker steps after tests #3690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3690 +/- ##
=======================================
Coverage 52.35% 52.35%
=======================================
Files 59 59
Lines 16880 16880
=======================================
Hits 8838 8838
Misses 7747 7747
Partials 295 295 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ciarams87
reviewed
Mar 27, 2023
ciarams87
approved these changes
Mar 28, 2023
shaun-nx
approved these changes
Mar 29, 2023
vepatel
approved these changes
Mar 29, 2023
This move the steps that build the docker images after the smoke tests.
lucacome
force-pushed
the
chore/rearrange-workflow
branch
from
2b3e409 to
2f079a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-arranges the steps and moves the build of the docker images after the smoke tests. This way the docker images can only be built after all the tests pass.