Skip to content

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Mar 16, 2023

Proposed changes

This PR adds an example of how to configure and deploy WAF policy bundle.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner March 16, 2023 15:36
@jjngx jjngx requested a review from vepatel March 16, 2023 15:36
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #3656 (18667d0) into main (dbce83c) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3656      +/-   ##
==========================================
+ Coverage   52.33%   52.35%   +0.02%     
==========================================
  Files          59       59              
  Lines       16880    16880              
==========================================
+ Hits         8834     8838       +4     
+ Misses       7749     7747       -2     
+ Partials      297      295       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel added this to the v3.1.0 milestone Mar 20, 2023
@jjngx jjngx requested a review from ADubhlaoich March 20, 2023 16:10
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks grand, flagged a few small things with edit suggestions.

Co-authored-by: Ciara Stacke <[email protected]>
Signed-off-by: Jakub Jarosz <[email protected]>
@jjngx jjngx merged commit b649666 into main Mar 21, 2023
@jjngx jjngx deleted the docs/apBundle branch March 21, 2023 13:08
jjngx added a commit that referenced this pull request Mar 21, 2023
jjngx added a commit that referenced this pull request Mar 21, 2023
@brianehlert brianehlert modified the milestones: v3.1.0, v3.3.0 Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants