Skip to content

Conversation

avahahn
Copy link
Contributor

@avahahn avahahn commented Jan 25, 2023

Signed-off-by: Ava Hahn [email protected]

NOTE

This PR should be merged only after the following:

  • NGINX Service Mesh 1.7 is released
  • go.mod is updated to point to the release version of the relevant NSM libraries.

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@avahahn avahahn requested a review from a team as a code owner January 25, 2023 19:16
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jan 25, 2023
@lucacome lucacome marked this pull request as draft January 25, 2023 19:17
@lucacome lucacome marked this pull request as draft January 25, 2023 19:17
@avahahn avahahn force-pushed the ava-spiffe-lib branch 2 times, most recently from feaeaea to f1c73f8 Compare January 25, 2023 23:22
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023

Codecov Report

Merging #3482 (45c24e0) into main (ff7fd17) will increase coverage by 0.16%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3482      +/-   ##
==========================================
+ Coverage   51.98%   52.14%   +0.16%     
==========================================
  Files          60       59       -1     
  Lines       16811    16763      -48     
==========================================
+ Hits         8739     8741       +2     
+ Misses       7775     7727      -48     
+ Partials      297      295       -2     
Impacted Files Coverage Δ
internal/k8s/controller.go 11.89% <0.00%> (-0.07%) ⬇️
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️
internal/k8s/configuration.go 95.79% <0.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@avahahn avahahn force-pushed the ava-spiffe-lib branch 4 times, most recently from d62786c to 5af2c34 Compare January 30, 2023 19:17
@github-actions github-actions bot added documentation Pull requests/issues for documentation and removed documentation Pull requests/issues for documentation labels Jan 30, 2023
@avahahn avahahn marked this pull request as ready for review January 31, 2023 00:18
@avahahn avahahn changed the title Draft: use new NSM Spiffe and Cert rotation library Use new NSM Spiffe and Cert rotation library Jan 31, 2023
@lucacome lucacome self-assigned this Feb 14, 2023
@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label Feb 14, 2023
@lucacome lucacome merged commit 84273d9 into nginx:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement Pull requests for new features/feature enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants