Skip to content

Conversation

ciarams87
Copy link
Contributor

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner January 20, 2023 14:28
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023

Codecov Report

Merging #3464 (43dcb32) into main (acc233d) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 43dcb32 differs from pull request most recent head a3bad78. Consider uploading reports for the commit a3bad78 to get more accurate results

@@            Coverage Diff             @@
##             main    #3464      +/-   ##
==========================================
- Coverage   51.98%   51.95%   -0.03%     
==========================================
  Files          60       60              
  Lines       16806    16806              
==========================================
- Hits         8736     8732       -4     
- Misses       7775     7777       +2     
- Partials      295      297       +2     
Impacted Files Coverage Δ
pkg/apis/configuration/validation/policy.go 91.16% <ø> (ø)
internal/k8s/validation.go 93.81% <100.00%> (ø)
...is/configuration/validation/globalconfiguration.go 88.33% <100.00%> (ø)
...g/apis/configuration/validation/transportserver.go 96.62% <100.00%> (ø)
pkg/apis/configuration/validation/virtualserver.go 94.38% <100.00%> (ø)
internal/k8s/configuration.go 95.43% <0.00%> (-0.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ciarams87 ciarams87 merged commit 1c7be73 into main Jan 23, 2023
@ciarams87 ciarams87 deleted the formatting-fixes branch January 23, 2023 10:44
@lucacome lucacome added the chore Pull requests for routine tasks label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants