Skip to content

Conversation

lucacome
Copy link

@lucacome lucacome commented Jan 19, 2023

The test containers were built 2 years ago and never updated. I've created a repo to keep track of them https://github.com/nginxinc/kic-test-containers.
This PR removes the source code (some) of those containers and updates the images in the YAML files to use the new containers.

@lucacome lucacome requested a review from a team as a code owner January 19, 2023 03:00
@lucacome lucacome self-assigned this Jan 19, 2023
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Pull requests/issues for documentation tests Pull requests that update tests labels Jan 19, 2023
@lucacome lucacome requested a review from vepatel January 19, 2023 03:02
@codecov-commenter
Copy link

Codecov Report

Merging #3454 (5da6cc8) into main (d51a554) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3454      +/-   ##
==========================================
- Coverage   51.95%   51.93%   -0.03%     
==========================================
  Files          60       60              
  Lines       16797    16797              
==========================================
- Hits         8727     8723       -4     
- Misses       7775     7777       +2     
- Partials      295      297       +2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.39% <0.00%> (-0.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome force-pushed the chore/move-test-containers branch from e7e14df to d24c61c Compare January 19, 2023 22:36
@lucacome lucacome merged commit bda355c into main Jan 20, 2023
@lucacome lucacome deleted the chore/move-test-containers branch January 20, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants