Skip to content

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Jan 13, 2023

Proposed changes

Update IC version in deployments/helm-chart-dos-arbitrator/Chart.yaml when running .hack/common-release-prep.sh.
https://github.com/nginxinc/kubernetes-ingress/blob/241e7a39f41218bd65b17331596b5ec1bb2936fb/deployments/helm-chart-dos-arbitrator/Chart.yaml#L6-L10

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the chore Pull requests for routine tasks label Jan 13, 2023
@haywoodsh haywoodsh force-pushed the chore/add-missing-files-to-update-ic-version branch from 51a59ee to 4308b98 Compare January 19, 2023 10:25
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Merging #3438 (38e3cd5) into main (be14d5f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3438   +/-   ##
=======================================
  Coverage   51.97%   51.97%           
=======================================
  Files          60       60           
  Lines       16811    16811           
=======================================
  Hits         8737     8737           
  Misses       7777     7777           
  Partials      297      297           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@haywoodsh haywoodsh force-pushed the chore/add-missing-files-to-update-ic-version branch from 4308b98 to 0f1c230 Compare January 20, 2023 18:02
@haywoodsh haywoodsh marked this pull request as ready for review January 20, 2023 18:35
@haywoodsh haywoodsh requested a review from a team as a code owner January 20, 2023 18:35
@haywoodsh haywoodsh enabled auto-merge (squash) January 24, 2023 10:45
@haywoodsh haywoodsh disabled auto-merge January 24, 2023 10:50
@haywoodsh haywoodsh merged commit 4efe4ef into main Jan 24, 2023
@haywoodsh haywoodsh deleted the chore/add-missing-files-to-update-ic-version branch January 24, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants