Skip to content

Conversation

pasmant
Copy link
Contributor

@pasmant pasmant commented Dec 20, 2022

Add for DoS the dashboard page and api, in the case '-nginx-status' cli argument is enable.

  • [V] I have read the CONTRIBUTING doc
  • [V] I have added tests that prove my fix is effective or that my feature works
  • [V] I have checked that all unit tests pass after adding my changes
  • [V] I have updated necessary documentation
  • [V] I have rebased my branch onto main
  • [V] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pasmant pasmant requested a review from a team as a code owner December 20, 2022 08:20
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Dec 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Merging #3379 (9d80922) into main (d4fef4c) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3379      +/-   ##
==========================================
- Coverage   51.83%   51.81%   -0.03%     
==========================================
  Files          60       60              
  Lines       16747    16747              
==========================================
- Hits         8681     8677       -4     
- Misses       7772     7774       +2     
- Partials      294      296       +2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.39% <0.00%> (-0.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx
Copy link
Contributor

jjngx commented Jan 4, 2023

@pasmant looks ok, could you please fill info required in the PR template, and description of performed tests?

@github-actions github-actions bot added the tests Pull requests that update tests label Jan 5, 2023
@pasmant
Copy link
Contributor Author

pasmant commented Jan 5, 2023

@pasmant looks ok, could you please fill info required in the PR template, and description of performed tests?

@jjngx filled the info required in the PR, and also added pytest to check the new relevant directives

@jjngx jjngx requested a review from vepatel January 5, 2023 12:09
@lucacome lucacome added this to the v3.1.0 milestone Jan 11, 2023
@lucacome lucacome merged commit 294640d into main Jan 11, 2023
@lucacome lucacome deleted the dos_api branch January 11, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation tests Pull requests that update tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants