Skip to content

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Dec 6, 2022

This commit addresses two issues flagged as problems in documentation. One is a small typo, the other is an incorrect link. Additionally, it adds a README to the docs subfolder to explain how to run a local Hugo instance for testing and the broad strokes of contributing.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

This commit addresses two issues flagged as problems in documentation.
One is a small typo, the other is an incorrect link. Additionally,
it adds a README to the docs subfolder to explain how to run a local
Hugo instance for testing and the broad strokes of contributing.
@ADubhlaoich ADubhlaoich requested a review from a team as a code owner December 6, 2022 16:12
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Dec 6, 2022
'namespaces' is erroneously spelled 'namespacess'
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Merging #3337 (8524ff5) into main (09364eb) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3337      +/-   ##
==========================================
- Coverage   51.58%   51.56%   -0.03%     
==========================================
  Files          60       60              
  Lines       16675    16675              
==========================================
- Hits         8602     8598       -4     
- Misses       7783     7785       +2     
- Partials      290      292       +2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.39% <0.00%> (-0.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ADubhlaoich and others added 2 commits December 9, 2022 16:49
This commit axes the guidance around the content style completely
and clarifies the instructions for Hugo, also mentioning the live reload
feature it has - which is useful when working on documentation.
ADubhlaoich and others added 4 commits December 22, 2022 17:13
Co-authored-by: Luca Comellini <[email protected]>
Signed-off-by: Alan Dooley <[email protected]>
In a previous commit, this link was erroneously changed based on a
report. Links should point to the latest release tag, and the correction
given was for a different document altogether.
Copy link
Contributor Author

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the Helm Operator change after farther investigation.

@lucacome lucacome merged commit 4719147 into main Jan 11, 2023
@lucacome lucacome deleted the ndd-66-minor-changes branch January 11, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants