Skip to content

Reseting default TLS settings and making them optional #3302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 17, 2023
Merged

Reseting default TLS settings and making them optional #3302

merged 12 commits into from
Jan 17, 2023

Conversation

jasonwilliams14
Copy link
Contributor

@jasonwilliams14 jasonwilliams14 commented Nov 23, 2022 •
edited by vepatel
Loading

Proposed changes

  • This sets the default-server-secret as optional.
  • It will be commented out in the CLI portion of the install.
  • Documentation will call out it is optional, and customers will need to manually remove the comment in order to enable it.
  • Helm and python tests are changed accordingly.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jasonwilliams14 jasonwilliams14 added the enhancement Pull requests for new features/feature enhancements label Nov 23, 2022
@jasonwilliams14 jasonwilliams14 requested a review from a team as a code owner November 23, 2022 16:02
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Nov 23, 2022
ciarams87
ciarams87 reviewed Nov 23, 2022
View reviewed changes
ciarams87
ciarams87 reviewed Nov 23, 2022
View reviewed changes
ciarams87
ciarams87 reviewed Nov 23, 2022
View reviewed changes
@jasonwilliams14 jasonwilliams14 changed the title Resettung default TLS settings and making them optional Reseting default TLS settings and making them optional Nov 23, 2022
@jasonwilliams14 @ciarams87
Apply suggestions from code review
9d88789 
agree with recommendations

Co-authored-by: Ciara Stacke <[email protected]>
Signed-off-by: Jason Williams - NGIИX <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022 •
edited
Loading

Codecov Report

Merging #3302 (c3c8947) into main (c19284f) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head c3c8947 differs from pull request most recent head cc25870. Consider uploading reports for the commit cc25870 to get more accurate results

@@            Coverage Diff             @@
##             main    #3302      +/-   ##
==========================================
+ Coverage   51.95%   51.96%   +0.01%     
==========================================
  Files          60       60              
  Lines       16797    16797              
==========================================
+ Hits         8727     8729       +2     
+ Misses       7775     7773       -2     
  Partials      295      295
Impacted Files Coverage Δ
...ternal/k8s/appprotect/app_protect_configuration.go 86.74% <0.00%> (+0.57%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Dec 7, 2022
@github-actions github-actions bot added the tests Pull requests that update tests label Jan 16, 2023
@vepatel vepatel requested review from ciarams87 and shaun-nx January 17, 2023 12:26
ciarams87
ciarams87 approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

shaun-nx
shaun-nx approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vepatel vepatel merged commit e439f67 into main Jan 17, 2023
@vepatel vepatel deleted the feat/tls-secret-remove branch January 17, 2023 14:29
@vepatel vepatel mentioned this pull request May 20, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@lucacome lucacome Awaiting requested review from lucacome

@haywoodsh haywoodsh Awaiting requested review from haywoodsh

@jjngx jjngx Awaiting requested review from jjngx

+1 more reviewer

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart tests Pull requests that update tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jasonwilliams14 @codecov-commenter @ciarams87 @shaun-nx @vepatel