Skip to content

Move Docker build into reusable workflows, add NAP WAF #3250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 17, 2022
Merged

Move Docker build into reusable workflows, add NAP WAF #3250

merged 3 commits into from
Nov 17, 2022

Conversation

lucacome
Copy link

@lucacome lucacome commented Nov 15, 2022 •
edited
Loading

  • Moves Docker builds into reusable workflows to limit repetition
  • Adds builds for NAP WAF and NAP WAF + DoS
  • Runs tests for NAP WAF

@lucacome lucacome self-assigned this Nov 15, 2022
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 15, 2022
@lucacome lucacome force-pushed the chore/add-waf-dos-images branch from 000203e to 6a61b31 Compare November 15, 2022 01:35
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022 •
edited
Loading

Codecov Report

Merging #3250 (a1539b3) into main (8e551d1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3250   +/-   ##
=======================================
  Coverage   52.67%   52.67%           
=======================================
  Files          59       59           
  Lines       16107    16107           
=======================================
  Hits         8484     8484           
  Misses       7341     7341           
  Partials      282      282

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome force-pushed the chore/add-waf-dos-images branch 5 times, most recently from 2ac8284 to fbb9339 Compare November 15, 2022 02:17
@github-actions github-actions bot added the tests Pull requests that update tests label Nov 15, 2022
@lucacome lucacome force-pushed the chore/add-waf-dos-images branch 7 times, most recently from ec3c489 to 10eb9e1 Compare November 15, 2022 17:18
@lucacome lucacome changed the title Add NAP WAF images to the pipeline Move Docker build into reusable workflows, add NAP WAF Nov 15, 2022
@lucacome lucacome marked this pull request as ready for review November 15, 2022 18:10
@lucacome lucacome requested a review from a team as a code owner November 15, 2022 18:10
@lucacome lucacome force-pushed the chore/add-waf-dos-images branch from df66f0a to 32a6fd1 Compare November 16, 2022 18:15
@lucacome lucacome merged commit 9899c07 into main Nov 17, 2022
@lucacome lucacome deleted the chore/add-waf-dos-images branch November 17, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haywoodsh haywoodsh Awaiting requested review from haywoodsh haywoodsh was automatically assigned from nginxinc/kic

@ciarams87 ciarams87 Awaiting requested review from ciarams87 ciarams87 was automatically assigned from nginxinc/kic

2 more reviewers

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lucacome lucacome

Labels

chore Pull requests for routine tasks tests Pull requests that update tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lucacome @codecov-commenter @jjngx @shaun-nx