Skip to content

Conversation

lucacome
Copy link

@lucacome lucacome commented Nov 8, 2022

The break is not needed.
Fixes:

internal/k8s/spiffe.go:80:4: SA4011: ineffective break statement. Did you mean to break out of the outer loop? (staticcheck)

@lucacome lucacome self-assigned this Nov 8, 2022
@lucacome lucacome requested a review from a team as a code owner November 8, 2022 23:29
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 8, 2022
@lucacome
Copy link
Author

lucacome commented Nov 8, 2022

@kate-osborn I can't add you as a reviewer (🤷‍♂️) but I'm tagging you since it was your code

@lucacome lucacome merged commit 09e92c3 into main Nov 10, 2022
@lucacome lucacome deleted the chore/remove-ineffective-break branch November 10, 2022 17:00
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants