Skip to content

Always print build info, add flags used #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2022
Merged

Always print build info, add flags used #3231

merged 2 commits into from
Nov 9, 2022

Conversation

lucacome
Copy link

@lucacome lucacome commented Nov 8, 2022

  • Moves the build info output to the beginning of main.go, so it will always print the info even if there are errors with the flags or somewhere else
  • Adds output of all the flags passed to the binary

@lucacome lucacome self-assigned this Nov 8, 2022
@lucacome lucacome requested a review from a team as a code owner November 8, 2022 21:28
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 8, 2022
@lucacome lucacome enabled auto-merge (squash) November 9, 2022 16:38
@lucacome lucacome merged commit 91f9da8 into main Nov 9, 2022
@lucacome lucacome deleted the chore/always-print-info branch November 9, 2022 16:41
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
@lucacome @coolbry95
Always print build info, add flags used (nginx#3231)
c7e31dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh haywoodsh approved these changes

@ciarams87 ciarams87 Awaiting requested review from ciarams87 ciarams87 was automatically assigned from nginxinc/kic

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacome @haywoodsh @jjngx