Skip to content

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Oct 19, 2022

Proposed changes

Docs changes for release 2.4.1

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested review from a team, lucacome, haywoodsh and shaun-nx October 19, 2022 14:37
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Oct 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Merging #3184 (c7ba666) into release-2.4 (68058c1) will increase coverage by 0.02%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release-2.4    #3184      +/-   ##
===============================================
+ Coverage        52.52%   52.55%   +0.02%     
===============================================
  Files               58       58              
  Lines            16070    16070              
===============================================
+ Hits              8441     8445       +4     
+ Misses            7351     7349       -2     
+ Partials           278      276       -2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.76% <0.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome marked this pull request as ready for review October 19, 2022 19:41
@lucacome lucacome merged commit 413c0bb into release-2.4 Oct 19, 2022
@lucacome lucacome deleted the r-2.4.1 branch October 19, 2022 23:07
ciarams87 pushed a commit that referenced this pull request Oct 21, 2022
Co-authored-by: Luca Comellini <[email protected]>
ciarams87 added a commit that referenced this pull request Nov 3, 2022
* Release 2.4.1 (#3184)

Co-authored-by: Luca Comellini <[email protected]>

* Update docs/content/technical-specifications.md

Co-authored-by: Jakub Jarosz <[email protected]>
Co-authored-by: Luca Comellini <[email protected]>
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
* Release 2.4.1 (nginx#3184)

Co-authored-by: Luca Comellini <[email protected]>

* Update docs/content/technical-specifications.md

Co-authored-by: Jakub Jarosz <[email protected]>
Co-authored-by: Luca Comellini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants