Watch subset of namespaces for secrets #3170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Codecov Report
@@ Coverage Diff @@
## main #3170 +/- ##
==========================================
- Coverage 52.54% 52.51% -0.04%
==========================================
Files 59 59
Lines 16080 16097 +17
==========================================
+ Hits 8450 8454 +4
- Misses 7351 7366 +15
+ Partials 279 277 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Needs some fixing/testing |
|
Tested and works as expected! |
ciarams87
reviewed
Nov 7, 2022
ciarams87
reviewed
Nov 7, 2022
ciarams87
reviewed
Nov 8, 2022
ciarams87
reviewed
Nov 8, 2022
ciarams87
reviewed
Nov 8, 2022
|
Looks good @hafe! Just a couple of other docs improvements I noticed, and a rebase to main, and we should be good to merge! Thanks so much for the contribution 😃 |
Add new command line option "watch-secret-namespace" that can be used to configure namespaces watched for secrets. Closes nginx#3154
Co-authored-by: Ciara Stacke <[email protected]>
ciarams87
reviewed
Nov 8, 2022
jjngx
approved these changes
Nov 9, 2022
coolbry95
pushed a commit
to coolbry95/kubernetes-ingress
that referenced
this pull request
Nov 18, 2022
* Watch subset of namespaces for secrets Add new command line option "watch-secret-namespace" that can be used to configure namespaces watched for secrets. Closes nginx#3154 * Apply suggestions from code review Co-authored-by: Ciara Stacke <[email protected]> * Update cmd/nginx-ingress/flags.go Co-authored-by: Ciara Stacke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new command line option "watch-secret-namespace" that can be used to configure namespaces watched for secrets.
Closes #3154
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.