-
Notifications
You must be signed in to change notification settings - Fork 2k
Add annotations for deployment and daemonset #3143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3143 +/- ##
=======================================
Coverage 52.52% 52.52%
=======================================
Files 58 58
Lines 16070 16070
=======================================
Hits 8441 8441
Misses 7351 7351
Partials 278 278 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lucacome
previously approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The suggestion will fix the spacing "problem" you mentioned.
Co-authored-by: Luca Comellini <[email protected]>
Co-authored-by: Luca Comellini <[email protected]>
lucacome
approved these changes
Oct 14, 2022
ciarams87
approved these changes
Oct 17, 2022
coolbry95
pushed a commit
to coolbry95/kubernetes-ingress
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Pull requests/issues for documentation
enhancement
Pull requests for new features/feature enhancements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This setting allows for applying annotations to helm deployments and daemonsets. This will allow the ability to add arbitraty non-identifying metadata to objects. Examples include release IDs, image hashes, registry addresses, git branches, timestamps for example. This enhancement allows for more options with the helm chart.
Checklist
Before creating a PR, run through this checklist and mark each as complete.