Skip to content

Conversation

jasonwilliams14
Copy link
Contributor

Proposed changes

This setting allows for applying annotations to helm deployments and daemonsets. This will allow the ability to add arbitraty non-identifying metadata to objects. Examples include release IDs, image hashes, registry addresses, git branches, timestamps for example. This enhancement allows for more options with the helm chart.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [x ] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • [ x] I have checked that all unit tests pass after adding my changes
  • [x ] I have updated necessary documentation
  • I have rebased my branch onto main
  • [x ] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jasonwilliams14 jasonwilliams14 added the enhancement Pull requests for new features/feature enhancements label Oct 13, 2022
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Oct 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Merging #3143 (49f3adc) into main (4e6caf0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3143   +/-   ##
=======================================
  Coverage   52.52%   52.52%           
=======================================
  Files          58       58           
  Lines       16070    16070           
=======================================
  Hits         8441     8441           
  Misses       7351     7351           
  Partials      278      278           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jasonwilliams14 jasonwilliams14 marked this pull request as ready for review October 13, 2022 13:56
lucacome
lucacome previously approved these changes Oct 14, 2022
Copy link

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The suggestion will fix the spacing "problem" you mentioned.

@lucacome lucacome requested review from a team, ciarams87 and jjngx October 14, 2022 19:57
@lucacome lucacome added this to the v2.5.0 milestone Oct 21, 2022
@lucacome lucacome merged commit 9e4230b into main Oct 21, 2022
@lucacome lucacome deleted the feat/helm-deployment-annotations branch October 21, 2022 22:08
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants