Skip to content

Conversation

lucacome
Copy link

Adds Schema file for Helm Chart https://helm.sh/docs/topics/charts/#schema-files

It will help validate that the correct values are used for example during install. This is the first pass at it, the second pass will be adding the required values for the chart and other enforcements.

@lucacome lucacome requested a review from a team September 29, 2022 23:04
@lucacome lucacome self-assigned this Sep 29, 2022
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Sep 29, 2022
Copy link
Contributor

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@lucacome lucacome force-pushed the feat/add-helm-schema branch from 6b0b3ab to 630c4c2 Compare October 4, 2022 21:28
@codecov-commenter
Copy link

Codecov Report

Merging #3113 (6b0b3ab) into main (44b04ba) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 6b0b3ab differs from pull request most recent head 630c4c2. Consider uploading reports for the commit 630c4c2 to get more accurate results

@@            Coverage Diff             @@
##             main    #3113      +/-   ##
==========================================
- Coverage   52.54%   52.52%   -0.03%     
==========================================
  Files          58       58              
  Lines       16069    16069              
==========================================
- Hits         8444     8440       -4     
- Misses       7349     7351       +2     
- Partials      276      278       +2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.39% <0.00%> (-0.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome merged commit af95533 into main Oct 4, 2022
@lucacome lucacome deleted the feat/add-helm-schema branch October 4, 2022 22:28
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
@lucacome lucacome added the helm_chart Pull requests that update the Helm Chart label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants