Eliminate dead code

[jjngx]

Proposed changes

This PR eliminates few dead code paths.

Note that the value of err returned by this func is always nil. This PR is a result of small refactoring that simplifies logic by removing dead code from the configs package.

// GetMapKeyAsStringSlice tries to find and parse a key in the map as string slice splitting it on delimiter.
func GetMapKeyAsStringSlice(m map[string]string, key string, _ apiObject, delimiter string) ([]string, bool, error) {
    if str, exists := m[key]; exists {
	slice := strings.Split(str, delimiter)
	return slice, exists, nil
    }
    return nil, false, nil
}

Refactored func:

// GetMapKeyAsStringSlice tries to find and parse a key in the map as string slice splitting it on delimiter.
func GetMapKeyAsStringSlice(m map[string]string, key string, _ apiObject, delimiter string) ([]string, bool) {
    if str, exists := m[key]; exists {
	slice := strings.Split(str, delimiter)
	return slice, exists
    }
    return nil, false
}

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto main
• I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

[shaun-nx]

👍

[codecov-commenter]

Codecov Report

Merging #3104 (64a88d8) into main (1bc5233) will increase coverage by 0.13%.
The diff coverage is 8.10%.

@@            Coverage Diff             @@
##             main    #3104      +/-   ##
==========================================
+ Coverage   52.25%   52.39%   +0.13%     
==========================================
  Files          58       58              
  Lines       16045    15997      -48     
==========================================
- Hits         8385     8381       -4     
+ Misses       7384     7338      -46     
- Partials      276      278       +2     

Impacted Files	Coverage Δ
internal/configs/annotations.go	24.00% <0.00%> (+0.92%)	⬆️
internal/configs/configmaps.go	22.04% <0.00%> (+1.66%)	⬆️
internal/configs/parsing_helpers.go	67.64% <100.00%> (ø)
internal/k8s/configuration.go	95.39% <0.00%> (-0.37%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more