Skip to content

Conversation

memes
Copy link

@memes memes commented Jul 15, 2022

Google Cloud's marketplace requires that the application report usage
metrics periodically to GCP's service endpoint. UBB Agent SDK is used
to send a count of 60 to the endpoint every 60 seconds, using credentials
added as a secret during marketplace provisioning. If the secret is
unavailable or invalid, ingress controller will terminate after five
successive failures.

GCP Marketplace is click-to-deploy only; in addition to ingress controller,
a deployer and tester container must be provided as a package.

This PR is related to issue #2859

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@brianehlert brianehlert linked an issue Jul 15, 2022 that may be closed by this pull request
5 tasks
@lucacome lucacome self-assigned this Nov 22, 2022
@memes memes requested a review from a team as a code owner December 7, 2022 18:27
@memes memes requested review from ciarams87, jjngx and lucacome December 7, 2022 18:27
@github-actions github-actions bot added dependencies Pull requests that update a dependency file documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart labels Dec 7, 2022
@memes memes force-pushed the feature/gcp_metered_billing branch from 09d93a6 to 0a33101 Compare January 10, 2023 05:20
Google Cloud's marketplace requires that the application report usage
metrics periodically to GCP's service endpoint. UBB Agent SDK is used
to send a count of 60 to the endpoint every 60 seconds, using credentials
added as a secret during marketplace provisioning. If the secret is
unavailable or invalid, ingress controller will terminate after five
successive failures.

Runtime requirements:

 - The embedded variable gcpServiceName must match the fully-qualified
   GCP service identifier, as established during product listing
 - A per-deployment Secret containing a customer identifier and JSON
   key that are used to authenticate to the usage-based billing
   endpoint

GCP Marketplace is click-to-deploy only; in addition to ingress controller,
a deployer and tester container must be provided as a package. The source
code for these containers is in a separate repo.
@memes memes force-pushed the feature/gcp_metered_billing branch from e8838eb to 2597bb4 Compare January 10, 2023 05:24
@codecov-commenter
Copy link

Codecov Report

Merging #2860 (2597bb4) into main (de43770) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2860      +/-   ##
==========================================
- Coverage   51.81%   51.76%   -0.05%     
==========================================
  Files          60       60              
  Lines       16747    16769      +22     
==========================================
+ Hits         8677     8681       +4     
- Misses       7774     7794      +20     
+ Partials      296      294       -2     
Impacted Files Coverage Δ
cmd/nginx-ingress/flags.go 30.28% <ø> (ø)
cmd/nginx-ingress/main.go 0.00% <0.00%> (ø)
internal/k8s/configuration.go 95.76% <0.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome
Copy link

lucacome commented May 5, 2023

Closing this as the implementation is now in https://github.com/nginxinc/kubernetes-ingress-gcp and the docs were added in #3561

Thanks again @memes !

@lucacome lucacome closed this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support GCP Marketplace deployment of NGINX+ ingress controller

3 participants