Skip to content

Makefile vars cannot be overridden as documented #3224

@hafe

Description

@hafe

Describe the bug

Makefile variables TAG and PREFIX are documented that they can be overridden by users. But they can not be overridden.

To have them overrideable is useful for users building their own image.

To Reproduce
Steps to reproduce the behavior:

  1. Deploy x to '...' using some.yaml
  2. View logs on '....'
  3. See error

Expected behavior
A clear and concise description of what you expected to happen.

Your environment

  • Version of the Ingress Controller - release version or a specific commit
  • Version of Kubernetes
  • Kubernetes platform (e.g. Mini-kube or GCP)
  • Using NGINX or NGINX Plus

Additional context
Add any other context about the problem here. Any log files you want to share.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions