Skip to content

Refactored card usage to remove card-layout shortcode #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: mainframe
Choose a base branch
from
Draft

Refactored card usage to remove card-layout shortcode #923

wants to merge 1 commit into from

Conversation

lamATnginx
Copy link
Contributor

@lamATnginx lamATnginx commented Aug 5, 2025 •
edited by ADubhlaoich
Loading

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩

@lamATnginx lamATnginx self-assigned this Aug 5, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner August 5, 2025 19:52
@lamATnginx lamATnginx added the enhancement New feature or request label Aug 5, 2025
@lamATnginx lamATnginx requested review from a team as code owners August 5, 2025 19:52
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-one NGINX One Console product/nginxaas NGINX as a Service for Azure product/agent NGINX Agent product/unit NGINX Unit tooling Back end, repository, Hugo, and all things not related to content labels Aug 5, 2025
@lamATnginx lamATnginx marked this pull request as draft August 5, 2025 19:52
ADubhlaoich
ADubhlaoich reviewed Aug 6, 2025
View reviewed changes
archetypes/landing-page.md
{{</card>}}
{{</card-section>}}
{{</card-layout>}}
{{<card-section isFeaturedSection="true">}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{<card-section isFeaturedSection="true">}}
{{<card-section isFeaturedSection="true">}}

Double-space. This applies to all versions of this change.

ADubhlaoich
ADubhlaoich approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there's excess whitespace in the section declaration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

Assignees

@lamATnginx lamATnginx

Labels
documentation Improvements or additions to documentation enhancement New feature or request product/agent NGINX Agent product/nginx-one NGINX One Console product/nginxaas NGINX as a Service for Azure product/unit NGINX Unit tooling Back end, repository, Hugo, and all things not related to content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamATnginx @ADubhlaoich