Skip to content

NGF: Update data plane configuration doc #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

salonichf5
Copy link

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Data plane configuration doc needs to be updated to reflect new changes in NginxProxy resource

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #ISSUE

nginx/nginx-gateway-fabric#3238

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@github-actions github-actions bot added documentation Improvements or additions to documentation product/ngf Issues related to NGINX Gateway Fabric labels May 6, 2025
@salonichf5 salonichf5 force-pushed the docs/data-plane-config branch from bcbd150 to b9a03d2 Compare May 6, 2025 21:18
@salonichf5 salonichf5 force-pushed the docs/data-plane-config branch from b9a03d2 to d6a1d0d Compare May 6, 2025 21:20
@salonichf5 salonichf5 requested a review from a team May 6, 2025 21:21
@salonichf5 salonichf5 marked this pull request as ready for review May 6, 2025 21:21
@salonichf5 salonichf5 requested a review from a team as a code owner May 6, 2025 21:21
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM, but noticed some stuff on a second pass.

@salonichf5 salonichf5 force-pushed the docs/data-plane-config branch from 40d0261 to 9738803 Compare May 7, 2025 17:39
@salonichf5 salonichf5 requested a review from sjberman May 7, 2025 17:40
@salonichf5 salonichf5 requested a review from sjberman May 7, 2025 18:59

## Configure infrastructure-related settings

You can configure deployment and service settings for all data plane instances by editing the `NginxProxy` resource at the Gateway or GatewayClass level. These settings can also be specified under the `nginx.` section in the Helm values file. You can edit things such as replicas, pod scheduling options, container resource limits, extra volume mounts, service types and load balancer settings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can configure deployment and service settings for all data plane instances by editing the `NginxProxy` resource at the Gateway or GatewayClass level. These settings can also be specified under the `nginx.` section in the Helm values file. You can edit things such as replicas, pod scheduling options, container resource limits, extra volume mounts, service types and load balancer settings.
You can configure deployment and service settings for all data plane instances by editing the `NginxProxy` resource at the Gateway or GatewayClass level. These settings can also be specified under the `nginx` section in the Helm values file. You can edit things such as replicas, pod scheduling options, container resource limits, extra volume mounts, service types and load balancer settings.

@salonichf5 salonichf5 force-pushed the docs/data-plane-config branch from 35d2870 to feabd3d Compare May 7, 2025 19:15
@salonichf5 salonichf5 requested a review from sjberman May 7, 2025 19:15
@salonichf5 salonichf5 merged commit 72ad28e into nginx:ngf-feature-cp-dp-split May 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/ngf Issues related to NGINX Gateway Fabric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants