Refactor RegistryClient to use npr-api model classes #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace manual JSON handling with npr-api models and Jackson ObjectMapper - Use CreatePluginReleaseRequest with fluent API for building requests - Use CreatePluginReleaseResponse for parsing responses - Add Jackson dependencies (jackson-databind and jackson-datatype-jsr310) - Register JavaTimeModule to handle OffsetDateTime fields - Fix test mocks to use proper PluginRelease fields instead of non-existent status field 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
|
@claude review |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
RegistryClientto leverage typed model classes from theio.seqera:npr-apilibrary instead of using raw maps and manual JSON construction. This improves type safety, maintainability, and ensures compatibility with the Nextflow Plugin Registry API specification.Key Changes
io.seqera:npr-api:0.15.0for typed API modelsjackson-databindandjackson-datatype-jsr310for JSON serializationcreateDraftRelease()now usesCreatePluginReleaseRequestandCreatePluginReleaseResponsemodelsBenefits
Testing
🤖 Generated with Claude Code