Skip to content

handle markdown links #5177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

handle markdown links #5177

wants to merge 7 commits into from

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Jul 21, 2025 •
edited
Loading

fix #4909

Note: Only marked down links are handled when a message contains both marked down links and plain URL's are present in a message.

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch marked this pull request as draft July 21, 2025 15:29
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9898
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code6161
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total9494

@sowjanyakch
extract markwon
465d779 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
handle markdown links
5fb1ae4 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
refactor
ee01481 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
markdown links work
649bf48 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
use proper naming + plugins
27aa10a 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
include copyright
0c0cae4 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
use constants
dfd5cb9 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch sowjanyakch marked this pull request as ready for review July 21, 2025 16:57
@sowjanyakch sowjanyakch self-assigned this Jul 21, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Jul 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5177-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@sowjanyakch sowjanyakch added 2. developing Work in progress don't merge and removed 3. to review Waiting for reviews labels Jul 30, 2025
@sowjanyakch sowjanyakch marked this pull request as draft July 30, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi Awaiting requested review from mahibi

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

At least 1 approving review is required to merge this pull request.

Assignees

@sowjanyakch sowjanyakch

Labels

2. developing Work in progress don't merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[markdown](https://nextcloud.com) does not appear as a link in a normal message, but does so when that message is quoted

1 participant

@sowjanyakch