feat: Implement ITriggerableProvider for task processing providers #683
+49
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements the ITriggerableProvider interface for AppAPI task processing providers, allowing providers to be externally triggered. This enhancement adds triggering capabilities to existing task processing providers by extending the anonymous provider class to implement the new interface.
- Adds ITriggerableProvider interface implementation to anonymous ExApp providers
- Implements a trigger() method that makes HTTP requests to external apps
- Updates constructor dependencies to support the triggering functionality
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
oleksandr-nc
approved these changes
Oct 21, 2025
Contributor
oleksandr-nc
left a comment
oleksandr-nc
left a comment
There was a problem hiding this comment.
looks good to me, if it is working good
Member
Author
|
Mh, after a test I can say with confidence: it's not working :D |
Member
Author
|
Tested and works |
marcelklehr
added a commit
to cloud-py-api/nc_py_api
that referenced
this pull request
Oct 22, 2025
See nextcloud/app_api#683 for the corresponding AppAPI PR. Changes proposed in this pull request: * Add a `trigger_handler` param to set_handlers() that will be called when the /trigger endpoint is requested by AppAPI. --------- Signed-off-by: Marcel Klehr <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See nextcloud/server#55741 for the server-implementation.