ALL ApiScope
#190
Merged
ALL ApiScope
#190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey18106
approved these changes
Jan 1, 2024
Signed-off-by: Andrey Borysenko <[email protected]>
bigcat88
added a commit
to cloud-py-api/nc_py_api
that referenced
this pull request
Jan 1, 2024
This code were not working:
```python3
nc.ocs("GET", "/ocs/v2.php/core/whatsnew")
```
this PR fixes it, for OCS that return `Http::STATUS_NO_CONTENT` we
return empty list.
In addition added `ALL` API scope, ref: nextcloud/app_api/pull/190
Previous commit:
8fd175a
was added fast to just implement `ALL` API scope tests in AppAPI repo.
---------
Signed-off-by: Alexander Piskun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
ALLApiScope to allow the use of OCS Apis that we have not yet defined in the AppAPI.Also with help of 993a111 AppAPI now correctly returns status 401 instead of 996 for Controllers protected by AppAPIAuth attribute.