Skip to content

feat: enhance unified search #15580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 6, 2025
Merged

feat: enhance unified search #15580

merged 5 commits into from
Oct 6, 2025

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Sep 8, 2025 •
edited
Loading

  • Tests written, or not not needed

Issue: nextcloud/files-clients#87

Demo

Screen_recording_20250930_155233.webm

@alperozturk96 alperozturk96 linked an issue Sep 8, 2025 that may be closed by this pull request
Enhance files search nextcloud/files-clients#87
Closed
@alperozturk96 alperozturk96 mentioned this pull request Sep 8, 2025
Closed
kra-mo
kra-mo approved these changes Sep 12, 2025
View reviewed changes
Copy link
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand, this looks good.

jancborchardt

This comment was marked as resolved.

Sign in to view

@alperozturk96 alperozturk96 force-pushed the feat/enhance-unified-search branch 2 times, most recently from cc1ffa0 to bbf8db6 Compare September 30, 2025 12:42
@alperozturk96
Copy link
Collaborator Author

alperozturk96 commented Sep 30, 2025 •
edited
Loading

PR is updated. Issue that exists on master and this PR will be handled in different PR.

@alperozturk96 alperozturk96 force-pushed the feat/enhance-unified-search branch from abd537c to ede66e8 Compare October 6, 2025 11:43
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15580.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Codacy

Lint

TypemasterPR
Warnings4545
Errors1111

SpotBugs

CategoryBaseNew
Bad practice4646
Correctness7474
Dodgy code268268
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3535
Performance4949
Security1818
Total500500

@alperozturk96 alperozturk96 merged commit 3242b07 into master Oct 6, 2025
17 of 20 checks passed
@alperozturk96 alperozturk96 deleted the feat/enhance-unified-search branch October 6, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@kra-mo kra-mo kra-mo approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhance files search

4 participants

@alperozturk96 @jancborchardt @kra-mo