Finish PreviewImageActivity After Image Deletion #14782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alperozturk <[email protected]>
alperozturk96
requested review from
tobiasKaminsky
and removed request for
tobiasKaminsky
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14782.apk |
ZetaTom
approved these changes
Apr 23, 2025
alperozturk96
deleted the
finish-preview-image-activity-after-delete-image
branch
PhilLab
added a commit
to PhilLab/nextcloud-android
that referenced
this pull request
Sep 21, 2025
The patch added in nextcloud#14782 prevented that the callback onRemoteOperationFinish() was ever called. Secondly, the manual update of adapter and pager is only needed if user is not present. When user is present, the initViewPager() takes care of everything.
PhilLab
added a commit
to PhilLab/nextcloud-android
that referenced
this pull request
Sep 21, 2025
The patch added in nextcloud#14782 prevented that the callback onRemoteOperationFinish() was ever called. Secondly, the manual update of adapter and pager is only needed if user is not present. When user is present, the initViewPager() takes care of everything. Signed-off-by: Philipp Hasper <[email protected]>
alperozturk96
pushed a commit
to PhilLab/nextcloud-android
that referenced
this pull request
Oct 6, 2025
The patch added in nextcloud#14782 prevented that the callback onRemoteOperationFinish() was ever called. Secondly, the manual update of adapter and pager is only needed if user is not present. When user is present, the initViewPager() takes care of everything. Signed-off-by: Philipp Hasper <[email protected]>
PhilLab
added a commit
to PhilLab/nextcloud-android
that referenced
this pull request
Oct 17, 2025
The patch added in nextcloud#14782 prevented that the callback onRemoteOperationFinish() was ever called. Secondly, the manual update of adapter and pager is only needed if user is not present. When user is present, the initViewPager() takes care of everything. Signed-off-by: Philipp Hasper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce?