Skip to content

Conversation

@docjyJ
Copy link
Collaborator

@docjyJ docjyJ commented Sep 27, 2025

You said:

FYI: you can now use string replacement in nextcloud_exec_commands since #6835.

@docjyJ docjyJ self-assigned this Sep 27, 2025
@docjyJ docjyJ added 1. to develop Accepted and waiting to be taken care of enhancement New feature or request labels Sep 27, 2025
@docjyJ docjyJ added this to the next milestone Sep 27, 2025
Signed-off-by: Jean-Yves <[email protected]>
@docjyJ
Copy link
Collaborator Author

docjyJ commented Sep 27, 2025

There remains the issue of the configuration ID.

@szaimen
Copy link
Collaborator

szaimen commented Sep 29, 2025

Hey :)

The problem that I see with this automatic configuration is that it will run the command every time the nextcloud container restarts. So it will add new configurations all the time. If we want to automate this, we need to add a check that the config is not existing yet.

I am also not sure if we run into a limitation regarding max characters at some point because the commands are added to the Nextcloud container via 1 env...

@docjyJ
Copy link
Collaborator Author

docjyJ commented Sep 30, 2025

The problem that I see with this automatic configuration is that it will run the command every time the nextcloud container restarts. So it will add new configurations all the time. If we want to automate this, we need to add a check that the config is not existing yet.

One thing that would be nice is to be able to define an ID, such as occ ldap:create-empty-config --name aio-lldap. I will look at the LDAP code and maybe try to open a PR.

I am also not sure if we run into a limitation regarding max characters at some point because the commands are added to the Nextcloud container via 1 env...

It seems that the limit is over 100,000 characters. See https://unix.stackexchange.com/questions/357843/setting-a-long-environment-variable-breaks-a-lot-of-commands

@szaimen
Copy link
Collaborator

szaimen commented Sep 30, 2025

The problem that I see with this automatic configuration is that it will run the command every time the nextcloud container restarts. So it will add new configurations all the time. If we want to automate this, we need to add a check that the config is not existing yet.

One thing that would be nice is to be able to define an ID, such as occ ldap:create-empty-config --name aio-lldap. I will look at the LDAP code and maybe try to open a PR.

Sounds good :)

I am also not sure if we run into a limitation regarding max characters at some point because the commands are added to the Nextcloud container via 1 env...

It seems that the limit is over 100,000 characters. See https://unix.stackexchange.com/questions/357843/setting-a-long-environment-variable-breaks-a-lot-of-commands

Ok cool. Lets hope that docker envs have the same limit :)

@docjyJ
Copy link
Collaborator Author

docjyJ commented Sep 30, 2025

PR open on Nextcloud, feedback welcome.

nextcloud/server#55424

@szaimen szaimen added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Oct 7, 2025
@szaimen szaimen modified the milestones: v11.10.0, next Oct 8, 2025
@szaimen szaimen modified the milestones: v11.11.0, next Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants