-
Notifications
You must be signed in to change notification settings - Fork 127
Reorder inheritance on span nodes #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder inheritance on span nodes #1539
Conversation
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop-hybrid-core-tracing #1539 +/- ##
================================================================
- Coverage 81.72% 71.38% -10.35%
================================================================
Files 207 207
Lines 23909 23904 -5
Branches 3789 3789
================================================================
- Hits 19540 17064 -2476
- Misses 3098 5302 +2204
- Partials 1271 1538 +267 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
01341fa
to
2fcf966
Compare
This is more of a general question: Originally, |
Core tracing will be adding a bunch of logic to the span_event method which is called via super on inheriting classes before those inheriting classes add additional attributes. In order for the core tracing logic to work correctly, this inheritance call order has to be reversed; the inheriting classes must first add the attributes and THEN call super.
51f9bbb
to
ec37cdc
Compare
40d0c3e
into
develop-hybrid-core-tracing
* Reorder inheritance on span nodes Core tracing will be adding a bunch of logic to the span_event method which is called via super on inheriting classes before those inheriting classes add additional attributes. In order for the core tracing logic to work correctly, this inheritance call order has to be reversed; the inheriting classes must first add the attributes and THEN call super. * Remove *args, **kwargs * [MegaLinter] Apply linters fixes --------- Co-authored-by: hmstepanek <[email protected]>
Overview
Core tracing will be adding a bunch of logic to the span_event method which is called via super on inheriting classes before those inheriting classes add additional attributes. In order for the core tracing logic to work correctly, this inheritance call order has to be reversed; the inheriting classes must first add the attributes and THEN call super.