Minor fixes to enable image building matching GIE #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CONTAINER_TOOL setting commented out until can be fixed correctly (Ref neuralmagic#7) - image name was missing `epp` as last element in tag Signed-off-by: Etai Lev Ran <[email protected]>
shaneutt
reviewed
Apr 18, 2025
shaneutt
approved these changes
Apr 18, 2025
This was
linked to
issues
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker buildcommand in Makefile #7)eppas last element in tag@clubanderson please note addition of
eppin image path (to match original GIE configuration of image names) and confirm it has no undesirable side effects in the rest of the pipeline