Skip to content

Conversation

@costas80
Copy link
Contributor

@costas80 costas80 commented May 5, 2023

PR to implement #686 .

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 88.76404% with 10 lines in your changes missing coverage. Please review.

Project coverage is 74.62%. Comparing base (6382ac6) to head (006b7c7).
Report is 203 commits behind head on master.

Files with missing lines Patch % Lines
...n/java/com/networknt/schema/BaseJsonValidator.java 55.55% 0 Missing and 4 partials ⚠️
...a/com/networknt/schema/SchemaValidatorsConfig.java 81.25% 1 Missing and 2 partials ⚠️
...in/java/com/networknt/schema/ErrorMessageType.java 50.00% 1 Missing ⚠️
src/main/java/com/networknt/schema/JsonSchema.java 50.00% 0 Missing and 1 partial ⚠️
...n/java/com/networknt/schema/ValidationMessage.java 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #743      +/-   ##
============================================
+ Coverage     74.54%   74.62%   +0.08%     
- Complexity     1052     1056       +4     
============================================
  Files           110      110              
  Lines          3665     3673       +8     
  Branches        708      708              
============================================
+ Hits           2732     2741       +9     
  Misses          651      651              
+ Partials        282      281       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevehu stevehu merged commit 1d674ad into networknt:master May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants