Skip to content

Conversation

@wheelerlaw
Copy link
Contributor

Closes #347

@codecov-io
Copy link

Codecov Report

Merging #348 (7dbc469) into master (6cb431f) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #348      +/-   ##
============================================
+ Coverage     69.86%   69.90%   +0.03%     
  Complexity      697      697              
============================================
  Files            80       80              
  Lines          2741     2741              
  Branches        568      569       +1     
============================================
+ Hits           1915     1916       +1     
+ Misses          612      610       -2     
- Partials        214      215       +1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/networknt/schema/JsonSchema.java 92.00% <0.00%> (+0.79%) 49.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb431f...7dbc469. Read the comment docs.

@stevehu stevehu merged commit c4b27b0 into networknt:master Nov 21, 2020
@stevehu
Copy link
Contributor

stevehu commented Nov 21, 2020

@wheelerlaw Thanks a lot for your contribution.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.90%. Comparing base (6cb431f) to head (7dbc469).
Report is 441 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/com/networknt/schema/JsonSchema.java 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #348      +/-   ##
============================================
+ Coverage     69.86%   69.90%   +0.03%     
  Complexity      697      697              
============================================
  Files            80       80              
  Lines          2741     2741              
  Branches        568      569       +1     
============================================
+ Hits           1915     1916       +1     
+ Misses          612      610       -2     
- Partials        214      215       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPE at JsonSchema.combineCurrentUriWithIds(JsonSchema.java:90)

4 participants