Skip to content

Maven Wrapper and Code Formatting for easier contributions #245

@ccudennec-otto

Description

@ccudennec-otto

Hi @UrielCh / @hezhangjian !

I hope you could relax after some exciting days 😃

I wanted to feedback two things that got my attention when contributing my last PR and I'm interested in what you think about it:

  • I used IntelliJ for writing the code and obviously my formatter settings were a little odd and introduced several whitespace changes. What do you think about using a formatting tool like Spotless in your project and reformat the code once?
  • I usually work with Gradle in my projects and didn't have Maven installed; that wouldn't be an issue if your projects would use the Maven wrapper to simplify setting up the project for newbies or one-time-contributors?

If you're interested in one or two of my ideas, I'm happy to raise a PR. 🙂

Cheers and thanks for your work!

Christopher

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions