NETOBSERV-1942 config / status views + NETOBSERV-1945 resource calculator #763

jpinsonneau · 2025-03-12T16:48:42Z

Description

Use console.page/route to replace original implementations
Setup replace the OLM form to help users create the firsts resources
Resource calculator integrated in the setup steps
Deploy plugin as 'static' when config is not provided
Most of the code under dynamic-form folder comes from https://github.com/openshift/console/tree/main/frontend/packages/console-shared/src/components/dynamic-form
- that could become a library if we get people interested maintaining it together

compressed.webm

This is a Poc. Code can be divided into multiple PRs if you feel it's needed:

Dependencies

NETOBSERV-2225 - Deploy static plugin at operator startup network-observability-operator#1345

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

openshift-ci · 2025-03-14T09:30:38Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jpinsonneau for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

codecov · 2025-03-14T09:33:55Z

Codecov Report

Attention: Patch coverage is 51.82482% with 66 lines in your changes missing coverage. Please review.

Project coverage is 55.37%. Comparing base (8c01669) to head (b146c12).

Files with missing lines	Patch %	Lines
web/moduleMapper/dummy.tsx	23.91%	35 Missing ⚠️
web/src/utils/yaml.ts	9.09%	10 Missing ⚠️
web/src/components/forms/dynamic-form/utils.ts	73.07%	7 Missing ⚠️
web/src/components/forms/config/templates.ts	57.14%	6 Missing ⚠️
pkg/server/routes.go	82.60%	2 Missing and 2 partials ⚠️
web/src/utils/k8s-models-hook.ts	33.33%	2 Missing ⚠️
pkg/config/config.go	87.50%	1 Missing ⚠️
web/src/components/netflow-traffic-tab.tsx	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
- Coverage   55.51%   55.37%   -0.14%     
==========================================
  Files         197      200       +3     
  Lines       10522    10633     +111     
  Branches     1226     1247      +21     
==========================================
+ Hits         5841     5888      +47     
- Misses       4312     4374      +62     
- Partials      369      371       +2

Flag	Coverage Δ
uitests	`57.72% <42.45%> (-0.24%)`	⬇️
unittests	`50.06% <83.87%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...b/src/components/drawer/netflow-traffic-drawer.tsx	`46.07% <100.00%> (ø)`
web/src/components/messages/error.tsx	`21.42% <100.00%> (ø)`
web/src/utils/url.ts	`77.41% <100.00%> (+0.37%)`	⬆️
pkg/config/config.go	`42.50% <87.50%> (+1.85%)`	⬆️
web/src/components/netflow-traffic-tab.tsx	`62.50% <50.00%> (ø)`
web/src/utils/k8s-models-hook.ts	`91.11% <33.33%> (-4.13%)`	⬇️
pkg/server/routes.go	`60.00% <82.60%> (-3.08%)`	⬇️
web/src/components/forms/config/templates.ts	`57.14% <57.14%> (ø)`
web/src/components/forms/dynamic-form/utils.ts	`73.07% <73.07%> (ø)`
web/src/utils/yaml.ts	`9.09% <9.09%> (ø)`
... and 1 more

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jpinsonneau · 2025-07-23T08:07:46Z

Rebased without changes

Co-authored-by: Mehul Modi <[email protected]>

jpinsonneau · 2025-07-23T08:39:51Z

(Yet another) Rebased without changes

github-actions · 2025-07-23T08:48:04Z

New image:
quay.io/netobserv/network-observability-console-plugin:b61a44a

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=b61a44a make set-plugin-image

jotak · 2025-07-23T10:08:57Z

web/src/components/forms/config/templates.ts

+import { K8sResourceKind } from '@openshift-console/dynamic-plugin-sdk';
+import { safeYAMLToJS } from '../../../utils/yaml';
+
+export const FlowCollector = `


this also will need to be auto-generated somehow; TODO as a follow-up

jotak · 2025-07-23T10:15:38Z

web/src/components/forms/dynamic-form/const.ts

@@ -0,0 +1,33 @@
+export const K8S_UI_SCHEMA = {


nit / ok for a follow-up: constants are not all-caps (see previously #541)

jotak · 2025-07-23T10:16:34Z

web/src/components/forms/dynamic-form/utils.spec.ts

@@ -0,0 +1,57 @@
+import { prune } from './utils';
+
+const PRUNE_DATA = {


same here: pruneData

jotak · 2025-07-23T10:16:47Z

web/src/components/forms/dynamic-form/utils.ts

+import * as _ from 'lodash';
+import { DynamicFormSchemaError } from './types';
+
+const UNSUPPORTED_SCHEMA_PROPERTIES = ['allOf', 'anyOf', 'oneOf'];


jotak

/lgtm

there will be some code style (all-capitals to camelcase) and linter warnings to fix in a follow-up
Other follow-ups that I can think of:

Auto-generate schema & samples
2d pass on text refinement and review again which fields to hide
Ellipsed text: append "..."

openshift-ci · 2025-07-23T11:09:27Z

@jpinsonneau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/plugin-cypress	`6c98f48`	link	true	`/test plugin-cypress`
ci/prow/qe-e2e-console-tests	`6c98f48`	link	false	`/test qe-e2e-console-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jotak · 2025-07-24T09:03:10Z

FYI I added my comments above in this follow-up task: https://issues.redhat.com/browse/NETOBSERV-2350 (feel free to add more feedback)

jotak · 2025-07-24T14:39:59Z

another round of testing will be done post-merge; merging now!

jpinsonneau marked this pull request as draft March 12, 2025 16:48

openshift-ci bot added the do-not-merge/work-in-progress label Mar 12, 2025

jpinsonneau force-pushed the 1942 branch from 1cf4f8f to bb14713 Compare March 14, 2025 09:30

jpinsonneau force-pushed the 1942 branch 6 times, most recently from 5d6fd6f to 12ec282 Compare March 20, 2025 16:29

memodi mentioned this pull request Mar 20, 2025

Updating containers digests references netobserv/network-observability-operator#1273

Merged

10 tasks

jpinsonneau force-pushed the 1942 branch 2 times, most recently from 7c1c429 to 28d93a4 Compare April 1, 2025 09:38

jpinsonneau mentioned this pull request Apr 2, 2025

NETOBSERV-2225 - Deploy static plugin at operator startup netobserv/network-observability-operator#1345

Merged

10 tasks

jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 2, 2025

jpinsonneau force-pushed the 1942 branch from 28d93a4 to 87e8be2 Compare April 2, 2025 12:05

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 2, 2025

jpinsonneau force-pushed the 1942 branch 3 times, most recently from f69f0df to 6ec375c Compare April 8, 2025 12:34

openshift-merge-robot added the needs-rebase label Apr 8, 2025

jpinsonneau force-pushed the 1942 branch from 4923465 to f8f270d Compare April 14, 2025 09:31

openshift-merge-robot removed the needs-rebase label Apr 14, 2025

netobserv deleted a comment from github-actions bot Apr 14, 2025

jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 14, 2025

jpinsonneau force-pushed the 1942 branch from f8f270d to 58f6328 Compare April 15, 2025 11:48

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 15, 2025

netobserv deleted a comment from github-actions bot Apr 15, 2025

jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 15, 2025

jpinsonneau and others added 12 commits July 23, 2025 10:39

wip

aeaae81

resource calculator

f8e6915

set sampling from consumption step

6ce3e44

added estimation & recommendation

c4af13a

fix style

a5aa139

Update web/src/components/forms/consumption.tsx

fa3ec31

Co-authored-by: Mehul Modi <[email protected]>

hide filters from forms

9e4b3f5

add scrolls and fit pipeline view

54a9784

status selections

d1ffcce

custom widget for secondary interfaces

ea185d7

checkboxes for features

0de5d17

removed unecessary fields in the setup and improve display

6c98f48

jpinsonneau force-pushed the 1942 branch from c98c5fe to 6c98f48 Compare July 23, 2025 08:39

jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 23, 2025

jpinsonneau removed the needs-changes To be added to denote PR needs changes or some questions/comments to be addressed label Jul 23, 2025

jotak changed the title ~~NETOBSERV-1942 PoC config / status views + NETOBSERV-1945 resource calculator~~ NETOBSERV-1942 config / status views + NETOBSERV-1945 resource calculator Jul 23, 2025

jotak reviewed Jul 23, 2025

View reviewed changes

jotak approved these changes Jul 23, 2025

View reviewed changes

openshift-ci bot assigned jotak Jul 23, 2025

openshift-ci bot added the lgtm label Jul 23, 2025

jotak merged commit ff0630c into netobserv:main Jul 24, 2025
9 of 12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

NETOBSERV-1942 config / status views + NETOBSERV-1945 resource calculator #763

NETOBSERV-1942 config / status views + NETOBSERV-1945 resource calculator #763

Uh oh!

jpinsonneau commented Mar 12, 2025 •

edited by jotak

Loading

Uh oh!

openshift-ci bot commented Mar 14, 2025

Uh oh!

codecov bot commented Mar 14, 2025 •

edited

Loading

Uh oh!

jpinsonneau commented Jul 23, 2025

Uh oh!

jpinsonneau commented Jul 23, 2025

Uh oh!

github-actions bot commented Jul 23, 2025

Uh oh!

jotak Jul 23, 2025

Uh oh!

jotak Jul 23, 2025

Uh oh!

jotak Jul 23, 2025

Uh oh!

jotak Jul 23, 2025

Uh oh!

jotak left a comment •

edited

Loading

Uh oh!

openshift-ci bot commented Jul 23, 2025

Uh oh!

jotak commented Jul 24, 2025

Uh oh!

jotak commented Jul 24, 2025

Uh oh!

Uh oh!

Uh oh!

		@@ -0,0 +1,57 @@
		import { prune } from './utils';

		const PRUNE_DATA = {

NETOBSERV-1942 config / status views + NETOBSERV-1945 resource calculator #763

NETOBSERV-1942 config / status views + NETOBSERV-1945 resource calculator #763

Uh oh!

Conversation

jpinsonneau commented Mar 12, 2025 • edited by jotak Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

openshift-ci bot commented Mar 14, 2025

Uh oh!

codecov bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jpinsonneau commented Jul 23, 2025

Uh oh!

jpinsonneau commented Jul 23, 2025

Uh oh!

github-actions bot commented Jul 23, 2025

Uh oh!

jotak Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

jotak Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

jotak Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

jotak Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

jotak left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jul 23, 2025

Uh oh!

jotak commented Jul 24, 2025

Uh oh!

jotak commented Jul 24, 2025

Uh oh!

Uh oh!

Uh oh!

jpinsonneau commented Mar 12, 2025 •

edited by jotak

Loading

codecov bot commented Mar 14, 2025 •

edited

Loading

jotak left a comment •

edited

Loading