feat: image cdn support #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for netlify-plugin-gatsby-demo canceled. 🔨 Explore the source changes: 6733c6e 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-gatsby-demo/deploys/621f722bfe678f00084e3d9c |
erezrokah
approved these changes
Mar 2, 2022
Contributor
Contributor
Author
|
Ah good point with the file link. I'll open an issue to add support for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Gatsby Image CDN. We do this using @netlify/ipx, which now has support for Gatsby's base64-encoded params.
This PR adds an ODB with
@netlify/ipx, and a rewrite from/_gatsby/image/*to that builder. It also sets the env varGATSBY_CLOUD_IMAGE_CDN, which enables this feature.The version in this PR can be installed as
@netlify/plugin-gatsby@images. For a live example using that release see: https://gatsby-image-cdn-demo.netlify.app/Example image
This PR temporarily changes the e2e tests to run
gatsby buildbefore the tests. This is to work around a bug introduced in Gatsby 4.9.0, which preventsgatsby buildrunning correctly in Jest. We can revert this once the bug is fixed.