Skip to content

Conversation

YujohnNattrass
Copy link
Contributor

@YujohnNattrass YujohnNattrass commented Jan 18, 2025

🎉 Thanks for submitting a pull request! 🎉

Summary

The Netlify API now uses types generated from the OpenAPI spec. However, some endpoints in the OpenAPI spec are incorrect. To prevent blocking progress, a temporary fix has been added to correct these types.

This is the PR that introduces the Netlify API types, which are causing the test failures.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@YujohnNattrass YujohnNattrass requested a review from a team as a code owner January 18, 2025 01:02
@renovate renovate bot force-pushed the renovate/netlify-packages branch from ed5a4dd to 14bd4b6 Compare January 20, 2025 11:08
@YujohnNattrass YujohnNattrass merged commit 529bfbb into renovate/netlify-packages Jan 21, 2025
6 checks passed
@YujohnNattrass YujohnNattrass deleted the update-types branch January 21, 2025 19:43
renovate bot added a commit that referenced this pull request Jan 21, 2025
* fix(deps): update netlify packages

* chore: fix ts types using that are using the Netlify API (#7000)

* fix(deps): update netlify packages

* chore: update ts types imported from Netlify API

* chore: run lint

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: YujohnNattrass <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants