Skip to content

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Apr 13, 2020

Thanks a lot for creating this Build plugin!

Netlify just released the latest version of Build plugins. Build plugins are currently enabled in the Netlify website for a small percentage of beta users.

This PR upgrades this plugin to the latest API. You can find the new documentation here.

Changes include:

  • Add a bugs field in package.json
  • Add a manifest.yml (including for default values)
  • Remove name property from plugin
  • Remove unused top-level function
  • Rename constants.BUILD_DIR to constants.PUBLISH_DIR
  • Thrown errors are reported as bugs by default and feature the name of the plugin, so errors can be directly propagated here (since they would indicate a bug in the plugin)
  • Remove the if (inputs.outputFile) condition since this input has a default value and providing false would make the plugin do nothing

I have done some quick tests, but you might want to manually test this PR as well just to make sure :)

@ehmicky ehmicky requested a review from DavidWells April 13, 2020 19:07
@ehmicky ehmicky self-assigned this Apr 13, 2020
@ehmicky ehmicky mentioned this pull request Apr 13, 2020
23 tasks
@ehmicky
Copy link
Contributor Author

ehmicky commented Apr 29, 2020

Is this ready to merge @DavidWells?

@DavidWells
Copy link
Contributor

Sure. Please feel free to merge all updates to any plugins you see fit 😃

@ehmicky ehmicky merged commit 415de3d into netlify-labs:master Apr 30, 2020
@ehmicky ehmicky deleted the feat/upgrade-netlify branch April 30, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants