Skip to content

Fix LateInitializationError in Llama dispose method #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2025
Merged

Fix LateInitializationError in Llama dispose method #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions lib/src/llama.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ class Llama {
int _nPos = 0;

bool _verbos = false;
bool _isInitialized = false; // Track if initialization is complete

bool _isDisposed = false;
LlamaStatus _status = LlamaStatus.uninitialized;
Expand Down Expand Up @@ -101,11 +102,12 @@ class Llama {
_initializeLlama(modelPath, mmprojPath, modelParamsDart,
contextParamsDart, samplerParams);

if (contextParamsDart != null) {
var contextParams = contextParamsDart.get();
batch = lib.llama_batch_init(contextParams.n_batch, 0, 1);
}
// Always initialize the batch, even if contextParamsDart is null
contextParamsDart ??= ContextParams();
var contextParams = contextParamsDart.get();
batch = lib.llama_batch_init(contextParams.n_batch, 0, 1);

_isInitialized = true; // Mark initialization as complete
_status = LlamaStatus.ready;
} catch (e) {
_status = LlamaStatus.error;
Expand Down Expand Up @@ -666,11 +668,22 @@ class Llama {
if (_tokens != nullptr) malloc.free(_tokens);
if (_tokenPtr != nullptr) malloc.free(_tokenPtr);
if (_smpl != nullptr) lib.llama_sampler_free(_smpl);
if (context.address != 0) lib.llama_free(context);
if (model.address != 0) lib.llama_free_model(model);

// Only access late fields if initialization was completed
if (_isInitialized) {
if (context.address != 0) lib.llama_free(context);
if (model.address != 0) lib.llama_free_model(model);

// Free the batch only if it was initialized
try {
lib.llama_batch_free(batch);
} catch (e) {
// Batch not initialized, ignore
}
}

// if (_mctx != nullptr) lib.mtmd_free(_mctx); // <- crash - double free

lib.llama_batch_free(batch);
lib.llama_backend_free();

_isDisposed = true;
Expand All @@ -693,7 +706,7 @@ class Llama {
_nPrompt = 0;
_nPos = 0;

if (context.address != 0) {
if (_isInitialized && context.address != 0) {
final mem = lib.llama_get_memory(context);
lib.llama_memory_clear(mem, true);
}
Expand Down