Skip to content

Fix To Allow Android To Work Out Of The Box #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Conversation

mcmah309
Copy link
Contributor

These changes allow the android to work out of the box.

A llama.cpp update was needed to bypass this llama issue ggml-org/llama.cpp#5537

Command use to update llama.cpp: flutter pub run ffigen

@netdur
Copy link
Owner

netdur commented Feb 22, 2024

@danemadsen ^^

@danemadsen
Copy link
Contributor

@danemadsen ^^

Ahh yeah I forgot to PR the update to llama.cpp

@netdur
Copy link
Owner

netdur commented Feb 23, 2024

@danemadsen what do you recommend, does PR #23 also resolve this workaround? or should I merge both?

@danemadsen
Copy link
Contributor

@danemadsen what do you recommend, does PR #23 also resolve this workaround? or should I merge both?

Yeah PR #23 does the same as this it just doesn't update the bindings. You can merge mine, merge both, it doesn't really matter

@netdur netdur merged commit 2253efe into netdur:main Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants