Closes #19865: Improve CableTypeChoices structure and grouping #20345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested review from
a team and
jeremystretch
and removed request for
a team
jeremystretch
requested changes
Sep 15, 2025
pheus
force-pushed
the
19865-tweak-cable-type-groupings
branch
2 times, most recently
from
d105d11 to
53fbdc0
Compare
Refactors `CableTypeChoices` by reorganizing cable types into more specific subcategories. Enhances clarity with distinct groups such as Copper (Twisted Pair, Twinax, Coaxial) and Fiber (Multi Mode, Single Mode, Other). Closes netbox-community#19865
pheus
force-pushed
the
19865-tweak-cable-type-groupings
branch
from
53fbdc0 to
755825d
Compare
|
Thanks for the review and the great suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19865
Summary
Regroups
CableTypeChoicesinto clearer headings to improve scanability of the cable type dropdown. This is a UI‑only change; no slugs or stored values are modified.Proposed UI grouping
Rationale
Makes the dropdown easier to read by grouping related families; keeps coax generic for now.
Backward compatibility
No breaking changes. Existing API slugs and database values remain unchanged.