-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Arm64 auto build #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm64 auto build #797
Conversation
86b68cb to
40ac752
Compare
|
Before I go deep into the code, I believe one problem remains: This build-process does not create multi-plattform images, does it? My quick scan revealed that it does not build & push the necessary manifest that combines both platform into one tagged image. It only builds images for both platforms, but keeps them independently. (Or is this manifest thing not necessary anylonger?) As an intermediate solution, we could publish |
|
When I check the tags on Docker Hub for my repository I do see one tag Inspect on AMD: https://controlc.com/90a16617 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've spotted some minor inconsistencies regarding SKIP_GIT. I believe they were in the script already, but it'd be great if you could fix them anyway.
d84e2c4 to
cee1b5b
Compare
Related Issue: #468
New Behavior
Contrast to Current Behavior
Discussion: Benefits and Drawbacks
releaseworkflow). Thepushworkflow runs the tests on both architecturesIMAGE_NAMESvariable that sets what was earlier set inDOCKER_REGISTRY,DOCKER_ORGandDOCKER_REPODOCKER_TARGETwas removed because the-ldapversion is integrated into the main image with Debianworkflow_dispatchoption is now enabled for thereleaseworkflow. Meaning it can be triggered manuallyChanges to the Wiki
Proposed Release Note Entry
Double Check
developbranch.