Fixes #34: Change Vendor Delimiter #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the split-delimiter from empty (white spaces) to comma. Because with white spaces as delimiter all vendors with a white space in their name cannot be imported (quotes didn't work in ENV strings).
For example:
docker run -e "VENDORS=Cisco Palo Alto " netbox-devicetype-import-libraryThis would be trated as three vendors.
Instead with comma as delimiter:
docker run -e "VENDORS=Cisco,Palo Alto" netbox-devicetype-import-libraryWould be treated as wo vendors like it should.
Merging this change means, that you have to use a comma separated vendor list instead of white space separated from now on.
But all the vendors with white spaces in thier name will then be supported as well (tested it already).
Fixes #34