Refactored validate_allocation to use tasks.UNIT_QUOTA_MULTIPLIERS when determining what attributes an allocation should have
#201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knikolla
requested changes
Apr 29, 2025
Collaborator
knikolla
left a comment
knikolla
left a comment
There was a problem hiding this comment.
Besides my 1 comment, looks good.
src/coldfront_plugin_cloud/management/commands/validate_allocations.py
Outdated
Show resolved
Hide resolved
QuanMPhm
force-pushed
the
refactor/validate_allo
branch
2 times, most recently
from
f2f5ab2 to
07add14
Compare
knikolla
approved these changes
May 6, 2025
when determining what attributes an allocation should have This is done by a function `get_expected_attributes` in `tasks.py` to fetch the list of expected attributes
QuanMPhm
force-pushed
the
refactor/validate_allo
branch
from
07add14 to
9242463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a small improvement, this will make
tasks.UNIT_QUOTA_MULTIPLIERSthe source of truth for what quota attributes any given allocation should have, making the code a bit easier to manage. This will also somewhat simplify the coding required to add the Openshift Virtualization resource type.