fix(vue_ls): make tsserver handler more resilient #4026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The current logic used unnecessary table merging even though there is only one element expected anyway. Solution: Just use index accessing and `or`
Problem: The current `on_init` of `vue_ls` requiers `vtsls` or `ts_ls` to already be attached, which is not always guaranteed. Solution: Add a retry mechanism that reruns the logic for some time to give the other ls a chance to catch up.
|
Thanks. configs really should not be implemented bespoke "retry" logic, hopefully this can be simplified after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After updating the Vue Language Server to version 3 I ran into the error "Could not find
ts_lsorvtslslsp client, required byvue_ls." at startup. It did not happen every time but most of the time. After playing around with as part of the discussion vuejs/language-tools#5603, I found out that it only happens when I have the lsp configurations in/after/lsp. If I configure everything in the same file the issue does not seem to occur.I presume that there is some kind of race condition going on which either does not or is far less likely to happen with a single configuration file.
Solution
In any case since I'm probably not the only one using the
/after/lspstyle of configuration, I think it makes sense to have some kind of solution within lspconfig.I added a retry into the handler that allows some time for the typescript ls to attach.
Additional notes