Skip to content

Conversation

thelonelyvulpes
Copy link
Contributor

@thelonelyvulpes thelonelyvulpes commented Jun 1, 2022

Remove code for handling null ids inline with updated specification regarding node/ relationship ids

Amends #672

@robsdedude
Copy link
Member

The driver still assumes that with freki disabled str(id) == element_id, which is not the case and needs fixing.

It's not guaranteed that `element_id == str(id_)` if the server provides both.
@thelonelyvulpes thelonelyvulpes merged commit 2b4f1c7 into 5.0 Jul 6, 2022
@thelonelyvulpes thelonelyvulpes deleted the feature/remove-null-tests-for-ids branch July 6, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants