Fix endless loop in Result.peek with fetch_size=1 #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement `ResultSingle` and `ResultPeek` in TestKit backend. `ResultSingle` will be deactivated for now as TestKit expects the driver to raise an error if there is not exactly 1 records in the result stream. Currently, the driver only warns if there are more and returns None if there are none. This (breaking) fix will be introduced in 5.0.
robsdedude
force-pushed
the
testkit-single-message
branch
from
99a94eb to
ff60660
Compare
robsdedude
added a commit
that referenced
this pull request
Sep 21, 2021
Backport of fix included in #587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
ResultSingleandResultPeekin TestKit backend.ResultSinglewill be deactivated for now as TestKit expects the driver toraise an error if there is not exactly 1 records in the result stream.
Currently, the driver only warns if there are more and returns None if there are
none. This (breaking) fix will be introduced in 5.0.