Discard transaction on disconnect #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't throw OSError on failed write, but BoltIncompleteCommitError or ServiceUnavailable. Since Python 3.3 IOError is an alias for OSError => canonicalize code.
When a network error occurs, the session should release the current connection as it's dead and acquire a new one for the next transaction.
technige
reviewed
Mar 31, 2021
robsdedude
commented
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A transaction is tied to the connection. If the connection dies, the transaction should die too. Previously, the session would try to rollback a transaction even if the transaction's connection died earlier.
To implement this, I decided to add an
on_network_errorcallback toResultandTransaction. While at it, I also refactored allIOErrors toOSErrors. The latter one is the canonical form for this type of error since Python 3.3 (https://docs.python.org/3/whatsnew/3.3.html#pep-3151-reworking-the-os-and-io-exception-hierarchy)