Skip to content

Conversation

@robsdedude
Copy link
Member

Session would retry a transaction even if it failed on commit. This is not desirable because the driver can't know if the transaction got successfully committed on the server's side or not.

@robsdedude robsdedude requested a review from technige March 25, 2021 15:58
@robsdedude
Copy link
Member Author

Actually there is a BoltIncompleteCommitError that's meant for internal use only. That's why Transaction translates it to a ServiceUnavailable Error.

@robsdedude robsdedude merged commit cdf8c83 into neo4j:4.3 Apr 6, 2021
@robsdedude robsdedude deleted the fix-no-retry-on-failed-commit branch April 6, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant