Skip to content

Conversation

robsdedude
Copy link
Member

Slightly change Neo4jError and ClientError:

  • Properties message and code are always a str (instead of str | None).
  • Remove possibility to override/set message and code properties.
  • Remove undocumented, internal methods Neo4jError.hydrate, Neo4jError.invalidates_all_connections,
    and Neo4jError.is_fatal_during_discovery.
  • Remove deprecated method Neo4jError.is_retriable.
    Use Neo4jError.is_retryable instead.
  • Change string representation of Neo4jError to include GQL error information.

Copy link
Contributor

@MaxAake MaxAake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬

Signed-off-by: Rouven Bauer <[email protected]>
@robsdedude robsdedude requested a review from MaxAake May 16, 2025 14:46
Copy link
Contributor

@MaxAake MaxAake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robsdedude robsdedude enabled auto-merge (squash) May 19, 2025 07:24
@robsdedude robsdedude merged commit 2659cb3 into neo4j:6.x May 19, 2025
20 checks passed
@robsdedude robsdedude deleted the errors/update-error-base-classes branch May 19, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants